Log a warning for slow SD cards #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichelgeson
approved these changes
Sep 22, 2024
morio
added a commit
to ZuluSCSI/ZuluSCSI-firmware
that referenced
this pull request
Oct 3, 2024
This code has been adapted from BlueSCSI/BlueSCSI-v2#191 It uses an updated SDFat library to report a warning if the SD card's speed class is below 10. Co-authored-by: androda <3105206+androda@users.noreply.github.com>
morio
added a commit
to ZuluIDE/ZuluIDE-firmware
that referenced
this pull request
Oct 4, 2024
This change warns the user if they are using an SD card below the speed class of 10. Based on the ZuluSCSI commit ZuluSCSI/ZuluSCSI-firmware@28f68ac which is based off of BlueSCSI/BlueSCSI-v2#191 Co-authored-by: androda <3105206+androda@users.noreply.github.com>
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slower SD cards can have pretty abysmal performance.
For example a class 2 card I tested benchmarked at 4MB read and 600kb write in SCSI Director.
These changes log a warning in this format just to point out that a slow card is being used, for example in the case of the Class 2 card I tested:
---- WARNING: Your SD Card Speed Class is 2. Class 10 or better is recommended for best performance.